There is a bug in ListAppendAsync

mdomashchenko · November 1, 2020, 2:56am

couchbase/couchbase-net-client/blob/1db7324cfaf665505d912df9f51dc5639fa8c1cb/Src/Couchbase/CouchbaseBucket.cs#L6722


/// </summary>
/// <param name="key">The key.</param>
/// <param name="value">The value.</param>
/// <param name="createList">If set to <c>true</c> [create list].</param>
/// <param name="timeout">The maximum time allowed for an operation to live before timing out.</param>
/// <returns>
/// A <see cref="T:Couchbase.IResult" /> with the operation result.
/// </returns>
public IResult ListAppend(string key, object value, bool createList, TimeSpan timeout)
{
    return ExecuteAndCreateDocumentIfMissing(
        () => MutateIn<object>(key).ArrayAppend(value, createList).WithTimeout(timeout).Execute(),
        key, new[] {value}, timeout, createList
    );
}

/// <summary>
/// Prepends a value to the front of a JSON array within a document.
/// </summary>
/// <param name="key">The key.</param>
/// <param name="value">The value.</param>

This call to ‘ExecuteAndCreateDocumentIfMissing’ uses the parameter timeout twice. First time in WithTimeout(timeout) which is a timeout for the operation and again as a parameter of the Execute function. That parameter is then used as expiration time if new document needs to be created in line 7827

github.com

couchbase/couchbase-net-client/blob/1db7324cfaf665505d912df9f51dc5639fa8c1cb/Src/Couchbase/CouchbaseBucket.cs#L7827


    return new DefaultResult
    {
        Success = true
    };
}

// if document doesn't exist and we can create it
if (result.Exception is DocumentDoesNotExistException && createDoc)
{
    // try and insert the document
    var insertResult = Insert(key, defaultValue, timeout);
    if (insertResult.Success)
    {
        return new DefaultResult
        {
            Success = true
        };
    }

    // we had a race and lost, try subdoc operation again
    if (result.Exception is DocumentAlreadyExistsException)

That makes no sense. The global timeout for operations is 2.5 sec, when ListAppendAsync creates me a new list, I need that list to stay around for an hour. Since the single timeout parameter is used for both in the current code, my new list only stays around for 2.5 sec. And if I pass 3600, then this would also be the timeout for the operation.

Same bug appears in every call to ExecuteAndCreateDocumentIfMissing in that file.

jmorris · November 2, 2020, 8:30pm

Hi @mdomashchenko -

Thanks for reporting; here is a ticket for tracking.

-Jeff

Topic		Replies	Views
Couchbase java client 2.6.0 - single insert fails with timeout Java SDK	2	1353	July 13, 2018
CouchbaseNetClient is expiring things way too quickly .NET SDK	3	3110	July 21, 2015
TimeoutException on creating multiple secondary indexes using java client Couchbase Server java	12	1715	November 4, 2019
Multiple UnambiguousTimeoutException for different requests .NET SDK dot-net	1	760	September 29, 2022
Couchbase.IO.SendTimeoutExpiredException: The operation has timed out .NET SDK dot-net	23	7713	March 19, 2018

There is a bug in ListAppendAsync

Related topics